-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds action to add log rate analysis to a case #201549
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good. Just left a few comments.
...omponents/log_rate_analysis/log_rate_analysis_content/log_rate_analysis_attachments_menu.tsx
Outdated
Show resolved
Hide resolved
...s/public/components/document_count_content/document_count_content/document_count_content.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update, LGTM!
Just one thing: Maybe we could move the cases functional test to a separate file log_rate_analysis_cases_embeddable.ts
- so if part of either suite fails not everything will be skipped.
const caseAttachmentTooltipContent = useMemo(() => { | ||
if (!showLogRateAnalysisResults) { | ||
return i18n.translate('xpack.aiops.logRateAnalysis.attachToCaseTooltipNoAnalysis', { | ||
defaultMessage: 'Run the analysis first to add results to a case', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage: 'Run the analysis first to add results to a case', | |
defaultMessage: 'Run the analysis first to add results to a case.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in: #33d5e29
} | ||
if (significantItems.length === 0) { | ||
return i18n.translate('xpack.aiops.logRateAnalysis.attachToCaseTooltipNoResults', { | ||
defaultMessage: 'Cannot add to case because the analysis did not produce any results', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage: 'Cannot add to case because the analysis did not produce any results', | |
defaultMessage: 'Cannot add to case because the analysis did not produce any results.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in: #33d5e29
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
cc @rbrtj |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12117919595 |
## Summary Follow up to [elastic#197247](elastic#197247) Adds action to add Log Rate Analysis Embeddable to a case. https://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit aa4c39c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…202431) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Adds action to add log rate analysis to a case (#201549)](#201549) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T10:59:54Z","message":"[ML] Adds action to add log rate analysis to a case (#201549)\n\n## Summary\r\n\r\nFollow up to [#197247](https://github.com/elastic/kibana/issues/197247)\r\n\r\nAdds action to add Log Rate Analysis Embeddable to a case.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"aa4c39c11955333176a612fd1b3601c34fcbc8ad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","v9.0.0","Team:ML","Feature:ML/AIOps","backport:version","v8.18.0"],"title":"[ML] Adds action to add log rate analysis to a case","number":201549,"url":"https://github.com/elastic/kibana/pull/201549","mergeCommit":{"message":"[ML] Adds action to add log rate analysis to a case (#201549)\n\n## Summary\r\n\r\nFollow up to [#197247](https://github.com/elastic/kibana/issues/197247)\r\n\r\nAdds action to add Log Rate Analysis Embeddable to a case.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"aa4c39c11955333176a612fd1b3601c34fcbc8ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201549","number":201549,"mergeCommit":{"message":"[ML] Adds action to add log rate analysis to a case (#201549)\n\n## Summary\r\n\r\nFollow up to [#197247](https://github.com/elastic/kibana/issues/197247)\r\n\r\nAdds action to add Log Rate Analysis Embeddable to a case.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"aa4c39c11955333176a612fd1b3601c34fcbc8ad"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
## Summary Follow up to [elastic#197247](elastic#197247) Adds action to add Log Rate Analysis Embeddable to a case. https://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Follow up to [elastic#197247](elastic#197247) Adds action to add Log Rate Analysis Embeddable to a case. https://github.com/user-attachments/assets/f45554e1-cef7-4c54-bea5-c509f236a956 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Follow up to #197247
Adds action to add Log Rate Analysis Embeddable to a case.
Screen.Recording.2024-11-26.at.14.06.37.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.